Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #19 - Memory Leak issues caused by Name or x:Name Area reference #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for issue #19 - Memory Leak issues caused by Name or x:Name Area reference #20

wants to merge 3 commits into from

Conversation

rogiardi
Copy link

  • Specific Dependency Property "AreaName" implementation to avoid Name or x:Name usage
  • IDisposable implementation
  • Remove method implementation on NotificationManager's cache

@rogiardi
fixed.
290a855 
(usage of Name or x:Name) make AreaControl instance static. Now NotificationArea implements IDisposable to make sure it's removed from MotificationManager's cache when Area is disposed.
A specific dependency property AreaName was added and used instead of Name and X.Name
@rogiardi
NotificationArea with Name property removed from xaml
2599a62
@rogiardi
variable areaIdentifier renamed back to areaName.
2d01c36
@rogiardi rogiardi changed the title issue #19 - Memory Leak issues caused by Name or x:Name Area reference Fix issue #19 - Memory Leak issues caused by Name or x:Name Area reference Jun 18, 2020
@rogiardi rogiardi changed the title Fix issue #19 - Memory Leak issues caused by Name or x:Name Area reference Fix for issue #19 - Memory Leak issues caused by Name or x:Name Area reference Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rogiardi